Fix: use correct encryption key for environment-specific secrets#83
Merged
Fix: use correct encryption key for environment-specific secrets#83
Conversation
jkebinger
approved these changes
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When encrypting secrets with
set-default --secretfor a specific environment (e.g., production), the CLI was using the wrong encryption key. It would fall back to the default environment's key instead of using the environment-specific key.Root Cause
The API returns environment IDs as strings (e.g.,
"1085"), but the code was using strict equality (===) to compare withNumber.parseInt(environmentId, 10), which returns a number. This caused the comparison to always fail:Fix
Changed the comparison to use string comparison:
Now when setting a secret in production, it correctly uses
PREFAB_SECRET_KEY_PRODinstead of falling back toPREFAB_SECRET_KEY.Changes
src/util/encryption.tsTesting
Verified that:
PREFAB_SECRET_KEY_PRODenv var